RFR: 8319813: Remove upper limit on number of compiler phases in phasetype.hpp [v4]

[Daniel Lundén]

On Tue, 21 Nov 2023 19:02:34 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address comments
>
> src/hotspot/share/compiler/compilerDirectives.cpp line 437:
> 
>> 435: #ifdef COMPILER2
>> 436:     if (!_modified[PrintIdealPhaseIndex]) {
>> 437:       // Parse ccstr and create mask
> 
> Could you update (or remove) this comment as part of the renaming?
> Please also update the comment on line 430:
> `    // Parse PrintIdealPhaseName and create an efficient lookup mask`

Thanks, both updated now

> src/hotspot/share/opto/phasetype.hpp line 163:
> 
>> 161:   char* _bad;
>> 162: 
>> 163: 
> 
> Please remove this empty line.

Thanks, removed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16729#discussion_r1401896341
PR Review Comment: https://git.openjdk.org/jdk/pull/16729#discussion_r1401896450