RFR: 8319813: Remove upper limit on number of compiler phases in phasetype.hpp [v5]

[Daniel Lundén]

On Wed, 22 Nov 2023 12:15:49 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix mask -> set in comments and remove empty line
>
> src/hotspot/share/opto/phasetype.hpp line 198:
> 
>> 196:   }
>> 197:   bool is_valid() const { return _valid; }
>> 198:   const char* what() const { return _bad; }
> 
> I suggest to either keep the old format with the return on a new line or add a new line between `phase_name_set()` and `is_valid()` to better separate it.

OK, reverted to old format with return on new line and new line separating the functions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16729#discussion_r1401981477