RFR: 8320347: Emulate vblendvp[sd] on ECore [v2]

[Volodymyr Paprotski]

On Tue, 21 Nov 2023 18:24:54 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Volodymyr Paprotski has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'jdk/master' into vp-ecore2
>>  - review comments
>>  - emulate vblend on ecores
>
> test/hotspot/jtreg/compiler/vectorization/TestSignumVector.java line 112:
> 
>> 110:             if (fout[i] != 1.0)   throw new RuntimeException("Expected positive numbers in second half of array: " + java.util.Arrays.toString(fout));
>> 111:         }
>> 112:     }
> 
> Its ok to add correctness check here, but test only intend to perform check IR validations, there are detailed function tests in following files
> test/hotspot/jtreg/compiler/intrinsics/math/TestSignumIntrinsic.java
> test/hotspot/jtreg/compiler/c2/cr6340864/TestFloatVect.java
> test/hotspot/jtreg/compiler/c2/cr6340864/TestDoubleVect.java

I am ok to remove this change to the test.. I didn't know where the other tests where and by the time I did find those, already added this. (Figured "more test === good", but its just duplicate)

> test/hotspot/jtreg/compiler/vectorization/runner/BasicFloatOpTest.java line 119:
> 
>> 117:             }
>> 118:         }
>> 119: 
> 
> Test performs IR validation, you can also update existing functional test with more test values.
> test/hotspot/jtreg/compiler/intrinsics/math/TestFpMinMaxIntrinsics.java

Same as above, I am ok to remove this change to the test too.. I didn't know where the other tests where and by the time I did find those, already added this. (Figured "more test === good", but its just duplicate)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16716#discussion_r1402452121
PR Review Comment: https://git.openjdk.org/jdk/pull/16716#discussion_r1402452663