RFR: 8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity

Richard Reingruber rrich at openjdk.org
Fri Nov 24 14:19:05 UTC 2023


On Thu, 23 Nov 2023 16:43:19 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

> The `TypeEntries::type_unknown` logic uses a wrong register. This results in unnecessary profile updates if the type is already flagged as unknown. Doesn't cause VM errors, but may affect performance. However, I haven't seen performance impact in larger benchmarks.

Looks good.

-------------

Marked as reviewed by rrich (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16801#pullrequestreview-1748022200


More information about the hotspot-compiler-dev mailing list