RFR: 8320715: Improve the tests of test/hotspot/jtreg/compiler/intrinsics/float16

Hamlin Li mli at openjdk.org
Sun Nov 26 10:54:16 UTC 2023


Hi,
Can you review the patch to improve the tests of test/hotspot/jtreg/compiler/intrinsics/float16?
Thanks.

Currently, there are several areas where improvements can be made:
1. test should not exit early before all test cases have run.
2. some output hide the data details, which should be printed out to help debug any potential issues, e.g. currently it could output some log like below in case of wrong implementation of a ConvF2HF intrinsic:
`Inconsistent result for Float.floatToFloat16(NaN/ff802000): fc01 != fc01`, which is rather confusing, not helpful. Suggested output would be: `Inconsistent result for Float.floatToFloat16(NaN/ff802000): fc01(64513) != fc01(-1023)`

-------------

Commit messages:
 - Initial commit

Changes: https://git.openjdk.org/jdk/pull/16815/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16815&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8320715
  Stats: 42 lines in 3 files changed: 26 ins; 0 del; 16 mod
  Patch: https://git.openjdk.org/jdk/pull/16815.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16815/head:pull/16815

PR: https://git.openjdk.org/jdk/pull/16815


More information about the hotspot-compiler-dev mailing list