RFR: 8320379: C2: Sort spilling/unspilling sequence for better ld/st merging into ldp/stp on AArch64
Fei Gao
fgao at openjdk.org
Mon Nov 27 07:00:07 UTC 2023
On Thu, 23 Nov 2023 15:34:24 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> This is a good idea, although the real-world gains are small. I'd wonder if this was worth doing for non-AArch64 ports, although even on others sorting the accesses into order might help.
>
>> Hi @theRealAph , thanks a lot for your review! All comments have been resolved in the new commit.
>>
>> > This is a good idea, although the real-world gains are small. I'd wonder if this was worth doing for non-AArch64 ports, although even on others sorting the accesses into order might help.
>>
>> Yeah, that's also bothering me. I'm not sure if it benefits other ports. Do you think if we need convert the change to aarch64-only? Thanks.
>
> #ifdefs are probably wrose, so I'd leave it as it is. We need another reviewer.
@theRealAph thanks for your review!
May I have another review? Maybe @vnkozlov? Thanks.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16754#issuecomment-1827227091
More information about the hotspot-compiler-dev
mailing list