RFR: 8320330: Improve implementation of RShift Value [v2]

[Jasmine Karthikeyan]

On Mon, 27 Nov 2023 08:09:09 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Jasmine Karthikeyan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unneeded cast
>>   
>>   Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>
> src/hotspot/share/opto/mulnode.cpp line 1411:
> 
>> 1409:   }
>> 1410: 
>> 1411:   return TypeLong::make((jlong)r1->get_con() >> (r2->get_con() & 63));
> 
> The cast to `jlong` can be removed since `get_con()` already returns a `jlong`.
> Suggestion:
> 
>   return TypeLong::make(r1->get_con() >> (r2->get_con() & 63));

Nice catch, thank you!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16736#discussion_r1405986624