RFR: 8319822: Use a linear-time algorithm for assert_different_registers() [v6]
Andrew Haley
aph at openjdk.org
Mon Nov 27 13:02:06 UTC 2023
On Mon, 27 Nov 2023 12:57:31 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> At the present time, `assert_different_registers()` uses an O(N**2) algorithm in assert_different_registers(). We can utilize RegSet to do it in O(N) time. This would be a useful optimization for all builds with assertions enabled.
>>
>> In addition, it would be useful to be able to static_assert different registers.
>>
>> Also, I've taken the opportunity to expand the maximum size of a RegSet to 64 on 64-bit platforms.
>>
>> I also fixed a bug: sometimes `noreg` is passed to `assert_different_registers()`, but it may only be passed once or a spurious assertion is triggered.
>
> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>
> Review feedback.
> Unfortunately, that didn't compile and I had make this change to get it to work: [stefank at d6bda1a](https://github.com/stefank/jdk/commit/d6bda1a25e297865fd6b5da21184273d8825b922)
Done, thanks and sorry for the delay.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16617#issuecomment-1827787981
More information about the hotspot-compiler-dev
mailing list