RFR: 8316422: TestIntegerUnsignedDivMod.java triggers "invalid layout" assert in FrameValues::validate [v3]

Tom Rodriguez never at openjdk.org
Tue Nov 28 04:07:06 UTC 2023


On Thu, 9 Nov 2023 00:24:18 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Don't truncate caller exception state stack in c1, even if no handlers are found.  This makes c1 follow the example of c2.  See bug for details.
>
> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add -XX:+IgnoreUnrecognizedVMOptions

Looks ok to me.

src/hotspot/share/c1/c1_ValueStack.hpp line 40:

> 38:     EmptyExceptionState, // Exception handling of instructions not covered by an xhandler
> 39:     CallerExceptionState,
> 40:     CallerEmptyExceptionState,

Maybe add a comment for these new kinds

-------------

Marked as reviewed by never (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16297#pullrequestreview-1751899678
PR Review Comment: https://git.openjdk.org/jdk/pull/16297#discussion_r1407054263


More information about the hotspot-compiler-dev mailing list