RFR: 8320715: Improve the tests of test/hotspot/jtreg/compiler/intrinsics/float16 [v2]

Tue Nov 28 18:05:09 UTC 2023

On Tue, 28 Nov 2023 17:34:27 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you review the patch to improve the tests of test/hotspot/jtreg/compiler/intrinsics/float16?
>> Thanks.
>> 
>> Currently, there are several areas where improvements can be made:
>> 1. test should not exit early before all test cases have run.
>> 2. some output hide the data details, which should be printed out to help debug any potential issues, e.g. currently it could output some log like below in case of wrong implementation of a ConvF2HF intrinsic:
>> `Inconsistent result for Float.floatToFloat16(NaN/ff802000): fc01 != fc01`, which is rather confusing, not helpful. Suggested output would be: `Inconsistent result for Float.floatToFloat16(NaN/ff802000): fc01(64513) != fc01(-1023)`
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix typo

Good.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16815#pullrequestreview-1753557024