Integrated: 8320715: Improve the tests of test/hotspot/jtreg/compiler/intrinsics/float16

Hamlin Li mli at openjdk.org
Wed Nov 29 08:04:18 UTC 2023


On Sun, 26 Nov 2023 10:48:44 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Hi,
> Can you review the patch to improve the tests of test/hotspot/jtreg/compiler/intrinsics/float16?
> Thanks.
> 
> Currently, there are several areas where improvements can be made:
> 1. test should not exit early before all test cases have run.
> 2. some output hide the data details, which should be printed out to help debug any potential issues, e.g. currently it could output some log like below in case of wrong implementation of a ConvF2HF intrinsic:
> `Inconsistent result for Float.floatToFloat16(NaN/ff802000): fc01 != fc01`, which is rather confusing, not helpful. Suggested output would be: `Inconsistent result for Float.floatToFloat16(NaN/ff802000): fc01(64513) != fc01(-1023)`

This pull request has now been integrated.

Changeset: 5dcf3a56
Author:    Hamlin Li <mli at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5dcf3a56cb425c3419273636729d2d83603be0d2
Stats:     44 lines in 3 files changed: 28 ins; 0 del; 16 mod

8320715: Improve the tests of test/hotspot/jtreg/compiler/intrinsics/float16

Reviewed-by: kvn

-------------

PR: https://git.openjdk.org/jdk/pull/16815


More information about the hotspot-compiler-dev mailing list