RFR: 8320911: RISC-V: Enable hotspot/jtreg/compiler/intrinsics/chacha/TestChaCha20.java [v2]

Fei Yang fyang at openjdk.org
Wed Nov 29 09:03:06 UTC 2023


On Wed, 29 Nov 2023 08:11:38 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you review this simple patch to enable TestChaCha20.java on riscv?
>> Thanks!
>> 
>> It's missed when working on JDK-8315716, so in this patch also add  `@requires` jtreg tag to make it obvious to spot which arch is supported.
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix comments

test/hotspot/jtreg/compiler/intrinsics/chacha/TestChaCha20.java line 111:

> 109:             if (containsFuzzy(cpuFeatures, "v", true)) {
> 110:                 System.out.println("Setting up vector worker");
> 111:                 configs.add(new ArrayList());

Hi, Thanks for the update. One more question: should we put `-XX:+UseRVV` in the list? Like `configs.add(List.of("-XX:+UseRVV"))`.
Just not sure whether it will work when running on some older linux kernels without hwprobe auto-detection for RVV extension.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16857#discussion_r1408957037


More information about the hotspot-compiler-dev mailing list