RFR: 8321141: VM build issue on MacOS after JDK-8267532

Vladimir Kozlov kvn at openjdk.org
Thu Nov 30 23:34:12 UTC 2023


[JDK-8267532](https://bugs.openjdk.org/browse/JDK-8267532) added new method `ciMethodData::exception_handler_bci_to_data()` which has `ShouldNotReachHere()` call on one exit without returning any value.

Unfortunately `ATTRIBUTE_NORETURN` attribute  in `ShouldNotReachHere()` seems don't work with older versions of Xcode.

The fix is to add `return` statement.

Tested with old Xcode (12.4) I have. Also tested with tier1 which includes builds.

-------------

Commit messages:
 - 8321141: VM build issue on MacOS after JDK-8267532

Changes: https://git.openjdk.org/jdk/pull/16914/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16914&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8321141
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/16914.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16914/head:pull/16914

PR: https://git.openjdk.org/jdk/pull/16914


More information about the hotspot-compiler-dev mailing list