RFR: 8317121: vector_masked_load instruction is moved too early after JDK-8286941

Vladimir Kozlov kvn at openjdk.org
Tue Oct 3 14:57:34 UTC 2023


On Tue, 3 Oct 2023 13:56:54 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> [AWS Graviton 3 instance types support 4x Neon 128bit / 2x SVE 256bit vectors and Graviton 2 instance types support 2x Neon 128bit vectors](https://github.com/aws/aws-graviton-getting-started#building-for-graviton2-graviton3-and-graviton3e)
>
> I think such flags/settings should only be part of an individual test if they are required to trigger a specific bug. Otherwise, we would need to add a lot of different flag combinations to a lot of tests. Instead, tests/tiers should be executed with such flag values regularly, for example, as part of a continuous integration system like we have here at Oracle.

> AWS Graviton 3 instance types support 4x Neon 128bit / 2x SVE 256bit vectors and Graviton 2 instance types support 2x Neon 128bit vectors

Good. If the test runs on this machine it will use SVE. HotSpot VM enable flags for CPU supported features. And Apple M1 does not have it. So we are covering both cases. You don't need to specify flags in test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16015#discussion_r1344255645


More information about the hotspot-compiler-dev mailing list