RFR: 8280120: [IR Framework] Add attribute to @IR to enable/disable IR matching based on the architecture [v2]

[Tobias Hartmann]

On Thu, 28 Sep 2023 08:54:07 GMT, Daniel Skantz <duke at openjdk.org> wrote:

>> This PR adds support for platform features in IR Framework preconditions. This allows us to write platform-specific IR checks in the same .java test file.
>> 
>> Platforms considered in this PR are: operating system, arch, and data model (32 or 64-bit VM). Supported field values correspond to vm.simpleArch, os.family, and vm.bits, as used in jtreg `@requires` fields. We use the Platform library methods to accomplish this. Otherwise, the new preconditions work similar to the corresponding CPUFeature preconditions.
>> 
>> Testing: T1-T3, GHA.
>> 
>> Additional testing: Tweaked SW test succeeds with removed `@requires` field and added IR platform precondition, but fails with just removed `@requires` field on 32-bit Linux. Performed a few spot tests with incorrectly formatted preconditions, and with valid platform checks but invalid counts.
>
> Daniel Skantz has updated the pull request incrementally with five additional commits since the last revision:
> 
>  - test method name
>  - whitespace
>  - whitespace
>  - platformFeature to platform. Lint docs. Add more tests.
>  - Add more platforms in IREncodingPrinter.java

Nice enhancement! Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15938#pullrequestreview-1657326240