Integrated: 8280120: [IR Framework] Add attribute to @IR to enable/disable IR matching based on the architecture
Daniel Skantz
duke at openjdk.org
Wed Oct 4 12:01:53 UTC 2023
On Wed, 27 Sep 2023 06:12:25 GMT, Daniel Skantz <duke at openjdk.org> wrote:
> This PR adds support for platform features in IR Framework preconditions. This allows us to write platform-specific IR checks in the same .java test file.
>
> Platforms considered in this PR are: operating system, arch, and data model (32 or 64-bit VM). Supported field values correspond to vm.simpleArch, os.family, and vm.bits, as used in jtreg `@requires` fields. We use the Platform library methods to accomplish this. Otherwise, the new preconditions work similar to the corresponding CPUFeature preconditions.
>
> Testing: T1-T3, GHA.
>
> Additional testing: Tweaked SW test succeeds with removed `@requires` field and added IR platform precondition, but fails with just removed `@requires` field on 32-bit Linux. Performed a few spot tests with incorrectly formatted preconditions, and with valid platform checks but invalid counts.
This pull request has now been integrated.
Changeset: a8549b63
Author: Daniel Skantz <daniel.skantz at oracle.com>
Committer: Emanuel Peter <epeter at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/a8549b63674be433617b986f392e4ff7afef5185
Stats: 285 lines in 6 files changed: 280 ins; 1 del; 4 mod
8280120: [IR Framework] Add attribute to @IR to enable/disable IR matching based on the architecture
Reviewed-by: rcastanedalo, epeter, thartmann
-------------
PR: https://git.openjdk.org/jdk/pull/15938
More information about the hotspot-compiler-dev
mailing list