RFR: 8312980: C2: "malformed control flow" created during incremental inlining [v2]

[Roland Westrelin]

On Wed, 4 Oct 2023 05:42:38 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - review
>>  - Merge branch 'master' into JDK-8312980
>>  - fix & test
>
> src/hotspot/share/opto/replacednodes.cpp line 127:
> 
>> 125:     }
>> 126: 
>> 127:     // Try to find some use of initial that are dominated by ctl so, initial can be replaced by improved.
> 
> Suggestion:
> 
>     // Try to find some use of initial that is dominated by ctl so, initial can be replaced by improved.

I rephrased that one in the new commit.

> src/hotspot/share/opto/replacednodes.cpp line 193:
> 
>> 191: }
>> 192: 
>> 193: void ReplacedNodes::clone_stack(Compile* C, Node* initial, Node* improved, const Node_Stack& stack, int i) const {
> 
> What about using a more descriptive name here like `clone_uses_and_replace` and maybe add a brief comment?

Done in the new commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15905#discussion_r1345732830
PR Review Comment: https://git.openjdk.org/jdk/pull/15905#discussion_r1345731859