RFR: 8316594: C2 SuperWord: wrong result with hand unrolled loops [v4]

Wed Oct 4 16:58:51 UTC 2023

On Wed, 4 Oct 2023 16:47:49 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Please read description in https://github.com/openjdk/jdk/pull/15864.
>> 
>> Currently, we only compare the first element of the load-pack with the StoreVector. This is not correct, we need to compare all elements of the load-pack with the StoreVector. Otherwise it may be that the first element lays below/before the memory region of the StoreVector (Less), but the last element of the load-pack for example could have overlap with the StoreVector (Equal).
>> 
>> Tier1-6 + stress-testing.
>> Performance testing.
>
> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   require avx2, so misalignment bug does not trigger

Update looks good.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15866#pullrequestreview-1658094623