RFR: 8282365: Optimize divideUnsigned and remainderUnsigned for constants [v25]

Emanuel Peter epeter at openjdk.org
Fri Oct 6 07:27:31 UTC 2023


On Fri, 6 Oct 2023 07:14:18 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   require x64
>
> test/hotspot/jtreg/compiler/integerArithmetic/DivisionByConstant.java line 37:
> 
>> 35:  * result.
>> 36:  *
>> 37:  * @requires os.simpleArch=="x64"
> 
> Can you move the `x64` requirement to the IR rule? This has just been made possible with [JDK-8280120](https://bugs.openjdk.org/browse/JDK-8280120)

Same with your other tests. That way, we can at least make sure that the results are correct on all other platforms.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/9947#discussion_r1348333281


More information about the hotspot-compiler-dev mailing list