RFR: 8313438: [s390x] build broken after JDK-8301996 [v2]

Martin Doerr mdoerr at openjdk.org
Fri Oct 6 11:17:54 UTC 2023


On Fri, 6 Oct 2023 10:55:06 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> src/hotspot/cpu/s390/templateTable_s390.cpp line 3032:
>> 
>>> 3030: 
>>> 3031: #ifdef ASSERT
>>> 3032:   const unsigned int bsize = is_static ? BTB_MINSIZE*1 : BTB_MINSIZE*8; // TODO: why code size is increasing ?
>> 
>> TODO should get resolved.
>
> Multiple test failures appeared after the code change with error: ` guarantee(len <= bsize) failed: block too large `, reducing it back is not a option as of now, but probably in future it could be shrink back to normal. So I've planned to deal with separately, as build is broken for now.

You don't need to make it smaller, now, but please improve the comment or file a JBS issue for that and remove the comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15885#discussion_r1348579300


More information about the hotspot-compiler-dev mailing list