RFR: 8313438: [s390x] build broken after JDK-8301996 [v2]

[Martin Doerr]

On Fri, 6 Oct 2023 10:56:37 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> src/hotspot/cpu/s390/templateTable_s390.cpp line 3006:
>> 
>>> 3004:   // Displacement is 0. No need to care about limited displacement range.
>>> 3005:   const Address field(fieldAddr);
>>> 3006:   __ lgr_if_needed(fieldAddr, off);
>> 
>> Was there a problem with the range? Why did it work in the old implementation?
>
> The comment is related to the uses of field. Depending on the instruction, disc is limited to be uimm12 or simm20. But the Address object is with displacement == 0.

I didn't get why the separate `agr` instructions are needed as part of this PR. Isn't that a separate issue?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15885#discussion_r1348578110