RFR: 8313438: [s390x] build broken after JDK-8301996 [v3]

[Martin Doerr]

On Fri, 6 Oct 2023 13:14:07 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Build Fix after JDK-8301996. 
>> 
>> Warnings related to new Lightweight locking scheme are seen during the build phase, but we will get rid of them, after integrating #14414 . Testing done for `release-vm`, `slowdebug-vm`, `fastdebug-vm` and `optimized-vm`.
>> 
>> 3 Test failures seen on s390x are un-related to these changes.
>> 
>> jdk/jshell/ClassMembersTest.java
>> java/lang/invoke/condy/CondyWrongType.java
>> java/lang/invoke/condy/CondyWithGarbageTest.java
>> 
>> JBS issue for test failures: [JDK-8317581](https://bugs.openjdk.org/browse/JDK-8317581).
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adds suggestions

Changes requested by mdoerr (Reviewer).

src/hotspot/cpu/s390/templateTable_s390.cpp line 3229:

> 3227:   NearLabel notVolatile;
> 3228: 
> 3229:   if (!flags.is_volatile()) {

This change is not legal. The property of the flag register has nothing to do with the bit in the content.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15885#pullrequestreview-1662838387
PR Review Comment: https://git.openjdk.org/jdk/pull/15885#discussion_r1349345372