RFR: 8317422: [JVMCI] concurrency issue in MethodData creation [v2]

Tobias Hartmann thartmann at openjdk.org
Mon Oct 9 05:45:08 UTC 2023


On Wed, 4 Oct 2023 20:57:17 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> `Method::build_profiling_method_data` is the safe way to create `MethodData` for a `Method` - it uses an atomic to do the write.
>> This PR updates `c2v_getFailedSpeculationAddress` and `c2v_reprofile` to use `Method::build_profiling_method_data`.
>
> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   made clear_method_data private and moved its definition inline

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16026#pullrequestreview-1663748281


More information about the hotspot-compiler-dev mailing list