RFR: 8282365: Optimize divideUnsigned and remainderUnsigned for constants [v25]

Quan Anh Mai qamai at openjdk.org
Mon Oct 9 14:41:28 UTC 2023


On Mon, 9 Oct 2023 14:15:57 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> The method is `int verify()` above, in the presence of `-Dverify=true`, a `DivINode` will trigger `IRViolationException` which is caught in the main method.
>
> Aha, I see now. Why not just put a positive rule with `count`?

I think it would be more comprehensive to test for success in the absence of the property and failure when it is present. We can test with a positive rule with `count` and flip the sense of the flag but that is indifferent. For detailed transformation we have tests in `compiler.c2.irTests` already. Thanks a lot.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/9947#discussion_r1350396004


More information about the hotspot-compiler-dev mailing list