RFR: 8316959: Improve InlineCacheBuffer pending queue management [v3]

Dean Long dlong at openjdk.org
Mon Oct 9 22:50:05 UTC 2023


On Mon, 9 Oct 2023 22:35:17 GMT, Dean Long <dlong at openjdk.org> wrote:

>>> I don't see why atomics are needed here. Any GC threads calling queue_for_release() should be finished, and now we are single-threaded at a safepoint.
>> 
>> I found the `xchg` more convenient than explicitly nulling out `_pending_release` in a separate statement. The implicit atomic op for `xchg` is just incidental (and won't have any impact on performance).
>> 
>> Will file an rfe about making this parallel.
>
> OK, a comment explaining that the atomic swap is convenient but not necessary would be helpful.

Nevermind, it looks like you reverted the swap.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16059#discussion_r1350932651


More information about the hotspot-compiler-dev mailing list