RFR: 8317763: Follow-up to AVX512 intrinsics for Arrays.sort() PR [v2]
Srinivas Vamsi Parasa
duke at openjdk.org
Tue Oct 10 19:03:42 UTC 2023
On Tue, 10 Oct 2023 17:55:43 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> pragma workround for GCC12 bug
>
> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 4176:
>
>> 4174:
>> 4175: // Load x86_64_sort library on supported hardware to enable avx512 sort and partition intrinsics
>> 4176: if (VM_Version::is_intel() && UseAVX > 2 && VM_Version::supports_avx512dq()) {
>
> I missed this in original changes - you don't need `UseAVX > 2` check here.
> We clear avx512dq flag when `UseAVX < 3` : [vm_version_x86.cpp#L939](https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/vm_version_x86.cpp#L939)
Please see this fixed in the latest commit pushed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16124#discussion_r1353147697
More information about the hotspot-compiler-dev
mailing list