RFR: 8313438: [s390x] build broken after JDK-8301996 [v4]

Amit Kumar amitkumar at openjdk.org
Wed Oct 11 05:12:32 UTC 2023


On Mon, 9 Oct 2023 10:31:25 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Build Fix after JDK-8301996. 
>> 
>> Warnings related to new Lightweight locking scheme are seen during the build phase, but we will get rid of them, after integrating #14414 . Testing done for `release-vm`, `slowdebug-vm`, `fastdebug-vm` and `optimized-vm`.
>> 
>> 3 Test failures seen on s390x are un-related to these changes.
>> 
>> jdk/jshell/ClassMembersTest.java
>> java/lang/invoke/condy/CondyWrongType.java
>> java/lang/invoke/condy/CondyWithGarbageTest.java
>> 
>> JBS issue for test failures: [JDK-8317581](https://bugs.openjdk.org/browse/JDK-8317581).
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   uses assert instead of if-statement

src/hotspot/cpu/s390/templateTable_s390.cpp line 280:

> 278: 
> 279:   if (JvmtiExport::can_post_breakpoint()) {
> 280:     NearLabel L_fast_patch;

Hi @RealLucy , @TheRealMDoerr 

Do you suggest to revert it back, so that situation like [JDK-8317851](https://bugs.openjdk.org/browse/JDK-8317851), could be avoided ? 

Thanks,

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15885#discussion_r1354109181


More information about the hotspot-compiler-dev mailing list