RFR: 8317763: Follow-up to AVX512 intrinsics for Arrays.sort() PR [v4]
Erik Joelsson
erikj at openjdk.org
Wed Oct 11 22:28:17 UTC 2023
On Wed, 11 Oct 2023 21:04:25 GMT, Srinivas Vamsi Parasa <duke at openjdk.org> wrote:
>> make/modules/java.base/Lib.gmk line 230:
>>
>>> 228: CFLAGS := $(CFLAGS_JDKLIB) $(LIBFFI_CFLAGS), \
>>> 229: LDFLAGS := $(LDFLAGS_JDKLIB) \
>>> 230: $(call SET_SHARED_LIBRARY_ORIGIN), \
>>
>> If you are going to fix the indentation here, please do it to follow the code conventions for the build system:
>> https://openjdk.org/groups/build/doc/code-conventions.html
>>
>> 2. If a line must be broken, use four spaces for indentation.
>> 18. Avoid padding internally in a line with spaces to try to align some feature into columns with surrounding lines.
>
> Hi Erik (@erikj79),
> BUILD_LIBFALLBACKLINKER is from different PR (#13079). If I understand correctly, for LIB_SIMD_SORT, are you suggesting that we don't pad the lines with spaces to align features into columns and instead just use 4 spaces for the indentation after the line break?
I see now that this is an unrelated change. In that case please avoid changing whitespace in unrelated files for this PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16124#discussion_r1355842271
More information about the hotspot-compiler-dev
mailing list