RFR: 8315024: Vector API FP reduction tests should not test for exact equality [v2]
Gergö Barany
gbarany at openjdk.org
Thu Oct 12 09:32:11 UTC 2023
On Wed, 4 Oct 2023 09:47:55 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Gergö Barany has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Address review comments
>
> Generally looks good, thanks for looking into this.
> I left a few comments below.
>
> Another concern I have, which I ran into by writing tests for the auto-vectorizer:
> Are we making sure the float/double reductions do not degenerate to either zero or infinity? Because if they do degenerate, then we have only a very weak test.
> I'm especially worried about all the values that depend on `i`, and then get multiplied. Don't the multiplications hit the maximal float value very quickly?
@eme64 would you have time to take another look at the changes I have made to this PR?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16024#issuecomment-1759259721
More information about the hotspot-compiler-dev
mailing list