RFR: 8310190: C2 SuperWord: AlignVector is broken, generates misaligned packs [v6]

[Emanuel Peter]

On Fri, 6 Oct 2023 23:54:44 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed up verify_vector_alignment in ad file
>
> src/hotspot/cpu/x86/x86.ad line 8985:
> 
>> 8983:     __ movq(Rtmp, Rr);    // copy r to tmp
>> 8984:     __ andq(Rtmp, Rmask); // mask off tmp
>> 8985:     __ cmpq(Rtmp, 0x0);   // check if zero
> 
> Since mask is constant the argument should be immL32 and `testq` instruction could be used instead these 3 instructions. See testL_reg_imm().

Thanks for the idea, done :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14785#discussion_r1356551269