RFR: 8310673: [JVMCI] batch compilation for libgraal should work the same way as for C2
Tobias Hartmann
thartmann at openjdk.org
Mon Oct 16 12:50:34 UTC 2023
On Mon, 16 Oct 2023 07:39:06 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
> There's extra logic in the CompileBroker for waiting for blocking JVMCI compilations to try and prevent deadlock ([JDK-8148507](https://bugs.openjdk.org/browse/JDK-8148507)). However, this is not relevant for libgraal which does not run Java code that can be accessing locks used by other threads.
>
> However, over time, this logic was extended to unblock a blocking compilation when a libgraal internal deadlock is detected. It turns out that this hides deadlocks or long compilations that should be solved in libgraal itself.
>
> This PR makes blocking compilation with libgraal the same as blocking compilations for C1 and C2.
>
> Testing: This has been tested for about 3 months against libgraal.
Looks reasonable to me.
-------------
Marked as reviewed by thartmann (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16197#pullrequestreview-1679901562
More information about the hotspot-compiler-dev
mailing list