RFR: 8295795: hsdis does not build with binutils 2.39+ [v5]

[Robbin Ehn]

On Wed, 18 Oct 2023 15:18:34 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> I still think we're talking past each other here.
> 
> I am talking about situation 3: We have built and installed it locally with `make install`, and have removed the installation directory (or at least points the configure argument to the installed directory).
> 
> In this case, you will not have a .libs directory.
> 
> I still don't see why it would be such big deal to check for the required files in both the directory directly, and then, if it is not found, check in a `.libs` directory? That's all I request, to increase the likelyhood that this works with many different kinds of setup.

Yes, as I have already said both in PR and in the comments, we do no support option 3, not now and not with this patch.
And the path you are suggesting (the one we have now) is wrong for "situation 3".

As you can see from the output above the library is moved from:
{source-dir}/bfd/.libs/libbfd.a to {install-dir}/lib/libbfd.a

You keep insisting that we should look in:
> That is, you need to break out the check for `libbfd.a`, and look for it first in `bfd` and secondly in `bfd/.libs`.

But an installation doesn't even have a "bfd" directory.

In all recent binutils 2.30->trunk it is always present in .libs/libbfd.a (again situation 3 is not support now and not with this patch)

Yes we should add for option 3, but that is not in scope here.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15138#issuecomment-1768789362