Integrated: 8318418: hsdis build fails with system binutils on Ubuntu
Daniel Jeliński
djelinski at openjdk.org
Thu Oct 19 10:39:48 UTC 2023
On Wed, 18 Oct 2023 09:31:22 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> hsdis-binutils.c doesn't use any functions from libiberty.h. This header is absent on Ubuntu (installed separately, and under a different path), so removing the include fixes the hsdis compilation on Ubuntu.
>
> Additionally, the static link library for libiberty is not needed on Ubuntu; I changed the autoconf check to make libiberty optional.
>
> Verification (Ubuntu):
> - build with-binutils=system works
> - build with-binutils-src=binutils-2.30 continues to work
> - build with-binutils-src=binutils-2.38 continues to work
>
> Source builds with versions newer than 2.38 fail, see #15138
This pull request has now been integrated.
Changeset: 3c70f2c1
Author: Daniel Jeliński <djelinski at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/3c70f2c1e9fb91cd5d7a66ef1e2a39672230208c
Stats: 5 lines in 2 files changed: 1 ins; 1 del; 3 mod
8318418: hsdis build fails with system binutils on Ubuntu
Reviewed-by: erikj, ihse
-------------
PR: https://git.openjdk.org/jdk/pull/16238
More information about the hotspot-compiler-dev
mailing list