RFR: Make the compiler/sharedstubs/SharedTrampolineTest.java require C2 explicitly [v2]
Tobias Hartmann
thartmann at openjdk.org
Thu Oct 19 12:23:43 UTC 2023
On Thu, 19 Oct 2023 11:07:52 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:
>> The test seem to only work with C2. A previous change to the test, the JDK-8314838, allowed for passing JVM arguments to the child process. However, if those parameters change the compiler used, the test fails.
>>
>> This PR makes this requirement (to have C2 as compiler) explicit.
>>
>> Testing: runs with '-XX:TieredStopAtLevel=3' with old version (failed), fixed version (skipped) and with new version but no additional arguments (passed).
>
> Evgeny Nikitin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Revert "8318471: ProblemList compiler/sharedstubs/SharedTrampolineTest.java"
>
> This reverts commit e25a49a993f270c33f7929e629fb3075a11fdec9.
> - Merge remote-tracking branch 'origin/master' into JDK-8318455/shared_trampoline_test_requires_c2/pub
> - 8318455: Make the compiler/sharedstubs/SharedTrampolineTest.java require C2 explicitly
I think I'm confused by this change from https://github.com/openjdk/jdk/pull/15609:
`@run driver compiler.sharedstubs.SharedTrampolineTest -XX:-TieredCompilation`
Where is the `-XX:-TieredCompilation` used or passed to?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16258#issuecomment-1770851561
More information about the hotspot-compiler-dev
mailing list