RFR: 8318306: java/util/Arrays/Sorting.java fails with "Array is not sorted at 8228-th position: 8251.0 and 8153.0"
Srinivas Vamsi Parasa
duke at openjdk.org
Thu Oct 19 18:10:36 UTC 2023
On Thu, 19 Oct 2023 17:15:51 GMT, Srinivas Vamsi Parasa <duke at openjdk.org> wrote:
>>> Thus the proposed fix is to add the guards for deoptimization to ensure that the correct pivotIndices is returned even when deoptimization happen
>>
>> Isn't the problem that we can deopt when calling into the runtime to allocate the array and that we then need to make sure that we re-execute the bytecode? Anyway, the fix looks good to me and is in-line with other places like `LibraryCallKit::inline_multiplyToLen` where we perform array allocation.
>
>> Isn't the problem that we can deopt when calling into the runtime to allocate the array and that we then need to make sure that we re-execute the bytecode?
>
> Please see the description updated to be technically correct, as suggested.
> @vamsi-parasa Thanks for the updates! Please add the micro as jtreg test.
@TobiHartmann
Thank you for your suggestions!
Please see the micro added as a jtreg test.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16230#issuecomment-1771406697
More information about the hotspot-compiler-dev
mailing list