RFR: 8318455: Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java

Evgeny Astigeevich eastigeevich at openjdk.org
Fri Oct 20 16:08:36 UTC 2023


On Fri, 20 Oct 2023 11:42:03 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/sharedstubs/SharedTrampolineTest.java line 53:
>> 
>>> 51:         String testClassName = SharedTrampolineTest.class.getName() + "$" + test;
>>> 52:         ArrayList<String> command = new ArrayList<String>();
>>> 53:         command.add("-XX:-TieredCompilation");  // C2-compiler only
>> 
>> It is not quite clear to me why we should not pass `args[0]` here, like we do in another test fix. 
>> Would this test ever make sense to run with different compiler, e.g. C1?
>
> Superficially, it looks like the test is optimised for C2. But let's ask @eastig for help.

I agree with Aleksey we should use `args[0]`. It looks like we will need to add a test for C1.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16277#discussion_r1367197023


More information about the hotspot-compiler-dev mailing list