RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v4]
Alan Bateman
alanb at openjdk.org
Mon Oct 23 12:21:31 UTC 2023
On Sat, 21 Oct 2023 10:56:01 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>> The Graal code base has [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) its module to `jdk.compiler.graal` as part of preparations for Project Galahad. Due to the way Java modules work, this requires a JDK change. The core of the issue is that the [service](https://github.com/openjdk/jdk/blob/56aa1e8dc8047cbc29d554889c64beb6eca0b8eb/src/jdk.internal.vm.ci/share/classes/module-info.java#L37) by which HotSpot requests a Graal compilation is defined in JVMCI. Since JVMCI is in the boot layer, the service can only be implemented by a provider in the boot layer and the package defining the service must be exported to the provider's defining module. This export currently targets [`jdk.internal.vm.compiler`](https://github.com/openjdk/jdk/blob/56aa1e8dc8047cbc29d554889c64beb6eca0b8eb/src/jdk.internal.vm.ci/share/classes/module-info.java#L28) and so the binding fails for the new Graal module. To address this, this PR reflects the Graal module ren
aming, including adjusting the qualified export.
>>
>> Edit: The target of the rename is now `jdk.graal.compiler` - see https://github.com/openjdk/jdk/pull/16189#issuecomment-1773764186
>
> Doug Simon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Merge tag 'jdk-22+18' into JDK-8318027_rename
>
> Added tag jdk-22+18 for changeset 3105538d
> - rename jdk.compiler.graal to jdk.graal.compiler
> - re-fix since tags to reflect current JDK release
> - fix copyright dates and @since tags to reflect history
> - rename jdk.internal.vm.compiler* to jdk.compiler.graal*
Marked as reviewed by alanb (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/16189#pullrequestreview-1692387518
More information about the hotspot-compiler-dev
mailing list