RFR: 8318609: Upcall stubs should be smaller [v2]
Martin Doerr
mdoerr at openjdk.org
Mon Oct 23 13:05:04 UTC 2023
On Mon, 23 Oct 2023 10:32:43 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Move JNIHandles::resolve(receiver) into C code.
>
> Hey Martin, the changes look good.
>
> Another thing we could do to reduce the size of the upcall stubs is move the exception handler to stub routines. The exception handler is the same for every upcall stub, but we generate one for each.
>
> I have a POC for x64/aarch64 that I've rebased that moves the exception handler out of line: https://github.com/openjdk/jdk/compare/master...JornVernee:jdk:Shared_E_Handler feel free to use that if you want. Or, I can address that separately.
@JornVernee: Thanks for the feedback! I've added your code and implemented it for all platforms.
@feilongjiang: Thanks for testing! Would you mind retesting the latest version?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16290#issuecomment-1775137130
More information about the hotspot-compiler-dev
mailing list