RFR: 8318455: Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java [v3]
Evgeny Astigeevich
eastigeevich at openjdk.org
Mon Oct 23 18:19:38 UTC 2023
On Mon, 23 Oct 2023 13:04:00 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:
>> A continuation of #16258.
>>
>> Said tests try to control the compilers used via arguments passed to subprocesses' they create. The [JDK-8314838](https://bugs.openjdk.org/browse/JDK-8314838) added support for additional forwarding of the JTReg javaoptions to the subprocesses, but broke the original arguments passing. They are now passed to the enclosing driver and simply ignored by ProcessTools.createTestJvm. As a result, proper compiler may be not chosen on subprocess start, etc. This PR fixes that.
>>
>> Testing: both tests run in CI, with additional arguments (tests were ignored, as expected) and without (passed).
>
> Evgeny Nikitin has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>
> - Merge master
> - Make SharedTrampolineTest also accept cmd-line compiler argument
> - 8318455: Fix the compiler/sharedstubs/SharedTrampolineTest.java and SharedStubToInterpTest.java
lgtm
-------------
Marked as reviewed by eastigeevich (Committer).
PR Review: https://git.openjdk.org/jdk/pull/16277#pullrequestreview-1693217032
More information about the hotspot-compiler-dev
mailing list