RFR: 8309893: Integrate ReplicateB/S/I/L/F/D nodes to Replicate node
Eric Liu
eliu at openjdk.org
Tue Oct 24 06:50:31 UTC 2023
On Fri, 20 Oct 2023 06:40:11 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> This patch creates ReplicateNode to replace ReplicateB/S/I/L/F/DNode, like other vector nodes introduced recently, e.g., PopulateIndexNode and ReverseVNode, etc. This refers from:
>> https://mail.openjdk.org/pipermail/panama-dev/2020-April/008484.html
>>
>> After merging these nodes, code will be easier to maintain. E.g., matching rules can be simplified.
>>
>> Besides AArch64, this patch tries to keep other ad files as the same before, only supplies some necessary predicate. E.g., for matching rules using ReplicateB before, they are now matching Replicate with a new predicate "Matcher::vector_element_basic_type(n) == T_BYTE". This would be easy for review and lower risks.
>>
>> [TEST]
>> x86: Tested with option "-XX:UseAVX=0/1/2/3".
>> AArch64: Tested on SVE machine and Neon machine.
>>
>> Full jtreg passed without new issue.
>
> @e1iu would you mind resolving the merge conflict? I will then send this to testing and review it afterwards.
@eme64 Hi Peter, I resolved the conflicts. They are mainly in jtreg test cases. Full jtreg passed on x86 machine (with option "-XX:UseAVX=0/1/2/3") and arm machines (SVE and NEON).
Please help to review, thanks.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14830#issuecomment-1776622911
More information about the hotspot-compiler-dev
mailing list