RFR: 8315024: Vector API FP reduction tests should not test for exact equality [v2]

Tobias Hartmann thartmann at openjdk.org
Tue Oct 24 09:01:51 UTC 2023


On Fri, 6 Oct 2023 18:34:52 GMT, Gergö Barany <gbarany at openjdk.org> wrote:

>> Certain floating point reduction operations in the Vector API are allowed to introduce rounding errors. Adjust the corresponding tests to allow a small relative error when comparing the operation's result to the expected value. Also, add a new generator `double[i / 10.0 + 0.1]` to test floating point operations with somewhat more interesting input data.
>
> Gergö Barany has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments

Looks reasonable to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16024#pullrequestreview-1694340922


More information about the hotspot-compiler-dev mailing list