RFR: 8317507: C2 compilation fails with "Exceeded _node_regs array" [v2]

[Dean Long]

On Wed, 25 Oct 2023 22:57:54 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add hand-unrolled regression test
>
> src/hotspot/share/adlc/output_c.cpp line 3132:
> 
>> 3130:     fprintf(fp_cpp, "  // Do not increment node index counter, since node reuses my index\n");
>> 3131:     fprintf(fp_cpp, "  Compile* C = Compile::current();\n");
>> 3132:     fprintf(fp_cpp, "  C->set_unique(C->unique() - 1);\n");
> 
> This code seems to be static with no specializations.  It would be nice if it could be in a regular .cpp file. The only complication seems to be including it only if `used` is set, which could translate into an #ifdef.

Or maybe something as simple as:

if (used) {
  fprintf(fp_cpp, "#include "machnode.cpp.inc"");
}

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16306#discussion_r1372402104