RFR: 8318586: Explicitly handle upcall stub allocation failure [v2]
Jorn Vernee
jvernee at openjdk.org
Thu Oct 26 13:03:34 UTC 2023
On Thu, 26 Oct 2023 12:17:22 GMT, David Holmes <dholmes at openjdk.org> wrote:
> Is stub allocation the same as other VM C heap exhaustion cases?
I think it depends on the particular case. e.g. `Unsafe::allocateMemory` can also throw OOME.
I think an allocation failure in the particular case of the FFM Linker allocating stubs, is something that we can reasonably report back to the user.
Looking at this again, I realize that we're also allocating a `BufferBlob` when creating the `CodeBuffer`, which is a far bigger allocation, and we never check whether that allocation fails either. I'll have a more thorough look at this.
I agree that bubbling up the allocation failures as OOME would be better.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16311#issuecomment-1781077051
More information about the hotspot-compiler-dev
mailing list