RFR: 8317507: C2 compilation fails with "Exceeded _node_regs array" [v2]
Dean Long
dlong at openjdk.org
Thu Oct 26 19:25:31 UTC 2023
On Thu, 26 Oct 2023 10:20:08 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> Or maybe something as simple as:
>>
>> if (used) {
>> fprintf(fp_cpp, "#include "machnode.cpp.inc"");
>> }
>
> Thanks for the suggestion, Dean. I am also a bit doubtful about having all this static code in `output_c.cpp`, my suggestion would be simply moving the entire definition of `fill_new_machnode()` to `machnode.cpp` (as in https://github.com/openjdk/jdk/commit/7f5c739919b166354d96e190702a515bbd3b3f5a). But I think it is better to address this (pre-existing) issue in a separate RFE and keep this bug fix small. What do you think?
A separate RFE is fine. Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16306#discussion_r1373713630
More information about the hotspot-compiler-dev
mailing list