RFR: JDK-8318016: Per-compilation memory ceiling [v2]

Thomas Stuefe stuefe at openjdk.org
Fri Oct 27 13:05:32 UTC 2023


On Fri, 27 Oct 2023 08:03:22 GMT, Roland Westrelin <roland at openjdk.org> wrote:

> That looks good to me. Have you done any stress testing? Maybe running compile the world with a low memory limit.

Many thanks @rwestrel .

I did stress testing by adding a random (low) limit and running GHAs with it. I also ran with -Xcomp -Xbatch. I found a bunch of missing bailout chains, which I took care of before posting this PR (https://bugs.openjdk.org/browse/JDK-8318445, https://bugs.openjdk.org/browse/JDK-8318183). 

But there are more (e.g. https://github.com/openjdk/jdk/pull/16375). We have been discussing a better way to care for these errors (I should have done this on the mailing list, sorry) and maybe introduce a semi-automatic way. Experiments of mine are here: https://github.com/openjdk/jdk/pull/16289 - but I try to find a way that is less invasive.

Finally, there is https://github.com/openjdk/jdk/pull/16247, which adds better diagnostic information to the hs-err file when we miss a bailout.

Bottom line, there are still outstanding issues with missing bailouts, and possibly a better solution at some point. In my view this does not prevent this RFE from going forward.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16220#issuecomment-1782880611


More information about the hotspot-compiler-dev mailing list