RFR: JDK-8283140: Remove unused encoding classes/operands from x86_64.ad [v2]
Quan Anh Mai
qamai at openjdk.org
Fri Oct 27 17:10:33 UTC 2023
On Wed, 25 Oct 2023 17:20:53 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:
>> These encoding classes became dead code when the instructions' definitions were patched to use the MacroAssembler.
>>
>> Tested with tier 1-3 on Linux, Windows & MacOS.
>
> Cesar Soares Lucas has updated the pull request incrementally with six additional commits since the last revision:
>
> - Update src/hotspot/cpu/x86/x86_64.ad
>
> Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
> - Update src/hotspot/cpu/x86/x86_64.ad
>
> Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
> - Update src/hotspot/cpu/x86/x86_64.ad
>
> Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
> - Update src/hotspot/cpu/x86/x86_64.ad
>
> Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
> - Update src/hotspot/cpu/x86/x86_64.ad
>
> Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
> - Update src/hotspot/cpu/x86/x86_64.ad
>
> Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
src/hotspot/cpu/x86/x86_64.ad line 5528:
> 5526: format %{ "movl $dst, $src\t# int stk" %}
> 5527: ins_encode %{
> 5528: __ movl $dst$$Address, $src$$Register);
Please fix this line.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16319#discussion_r1374843288
More information about the hotspot-compiler-dev
mailing list