RFR: 8316746: Top of lock-stack does not match the unlocked object [v2]

Martin Doerr mdoerr at openjdk.org
Sun Oct 29 16:42:46 UTC 2023


> It took me quite a long journey to figure out that C2 OSR goes wrong only in the test "vmTestbase/nsk/jdi/StepEvent" because the interpreter fills the slots in a different order as expected by C2. (Interpreter and C1 don't care about it.)
> I've reimplemented the search loop in `monitorenter`, improved comments and cleaned up the related code a bit. The test is passing with this change.

Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:

  Handle recursive locking like on other platforms. Improve register usage.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16406/files
  - new: https://git.openjdk.org/jdk/pull/16406/files/c2d36683..1e678fd2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16406&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16406&range=00-01

  Stats: 16 lines in 1 file changed: 2 ins; 1 del; 13 mod
  Patch: https://git.openjdk.org/jdk/pull/16406.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16406/head:pull/16406

PR: https://git.openjdk.org/jdk/pull/16406


More information about the hotspot-compiler-dev mailing list