RFR: 8318817: Could not reserve enough space in CodeHeap 'profiled nmethods' (0K)

[Johan Sjölen]

On Mon, 30 Oct 2023 15:18:55 GMT, Daniel Lundén <duke at openjdk.org> wrote:

>> src/hotspot/share/code/codeCache.cpp line 206:
>> 
>>> 204:   size_t min_size           = MAX3(os::vm_page_size(),
>>> 205:                                    os::vm_allocation_granularity(),
>>> 206:                                    ps);
>> 
>> Is there a VM configuration in which `ps` could be smaller than `os::vm_page_size()`? If not, we could simplify this expression to `MAX2(os::vm_allocation_granularity(), ps)`.
>
> I am not sure, which is why I took the safe route and also included `os::vm_page_size()`. Maybe @jdksjolen knows if what Roberto suggests is a safe assumption?

Hi,

I don't know, reading the code suggests that `ReservedCodeCacheSize/8` will determine whether `ps` can be smaller than `os::vm_page_size()` or not.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16373#discussion_r1376422041