RFR: 8318817: Could not reserve enough space in CodeHeap 'profiled nmethods' (0K) [v2]

[Thomas Stuefe]

On Mon, 30 Oct 2023 16:22:54 GMT, Daniel Lundén <duke at openjdk.org> wrote:

>> Hi,
>> 
>> I don't know, reading the code suggests that `ReservedCodeCacheSize/8` will determine whether `ps` can be smaller than `os::vm_page_size()` or not.
>
> @tstuefe: @dafedafe recommended that we ask you for advice on the above (possibly related to https://github.com/openjdk/jdk/pull/14903/). Do you know the details?

Without looking deep into this, something about this feels off. The original code using os::vm_page_size() should work fine, at least on non-Windows.

On almost all platforms all three values are identical. On AIX ps can be smaller than os::vm_page_size, and you probably don't care. On Windows, allocation granularity is 64k while pagesize is 4K.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16373#discussion_r1376559181