RFR: 8309893: Integrate ReplicateB/S/I/L/F/D nodes to Replicate node [v2]

Eric Liu eliu at openjdk.org
Tue Oct 31 10:19:33 UTC 2023


On Tue, 31 Oct 2023 10:12:41 GMT, Eric Liu <eliu at openjdk.org> wrote:

>> What would happen if I were to compare with a type that is larger? For example if I compared the bytes here with the value `1000`?
>
>> What would happen if I were to compare with a type that is larger? For example if I compared the bytes here with the value `1000`?
> 
> I suppose `javac` would complain since ByteVector.compare (https://github.com/openjdk/jdk/blob/master/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java#L2120) requires byte type.

> Is this ok, or rather a downgrade? Or maybe you should remove the `I` for int in the name?

It's a downgrade. Since now on SVE platform, after matching they were generated to the same MachNode. `VMASK_CMP_IMM_I_SVE` is used to align with the rules' name on AArch64.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14830#discussion_r1377356518


More information about the hotspot-compiler-dev mailing list